Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing copyright symbol (fixes brave/brave-browser#4990) #3832

Closed
wants to merge 1 commit into from

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 30, 2019

Fixes brave/brave-browser#4990. Script changes in brave/brave-browser#6771.

This also fixes a "Brave LLC" string in the copyright notice.

Submitter Checklist:

Test Plan:

On Desktop, open chrome://settings/help and check that the copyright symbol (C) is present.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 0.73.x - Nightly milestone Oct 30, 2019
@fmarier fmarier self-assigned this Oct 30, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mihaiplesa
Copy link
Collaborator

This is good to go, will fix the timeouts in a separate PR in b-b.

This also fixes a "Brave LLC" string in the copyright notice.
@fmarier fmarier force-pushed the francois-missing-copyright-symbol-4990-bc branch from 32584bd to f2b9a5d Compare November 5, 2019 19:28
@fmarier
Copy link
Member Author

fmarier commented Nov 5, 2019

Superseded by #3881.

@fmarier fmarier closed this Nov 5, 2019
@fmarier fmarier deleted the francois-missing-copyright-symbol-4990-bc branch June 10, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copyright (c) symbol in About Brave
3 participants